Skip to content

Don't generate RequestBody for parameters when disabledInferredBody is true #47659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 12, 2023

Conversation

captainsafia
Copy link
Member

Closes #47644

@captainsafia captainsafia requested a review from a team as a code owner April 11, 2023 23:59
@ghost ghost added the old-area-web-frameworks-do-not-use *DEPRECATED* This label is deprecated in favor of the area-mvc and area-minimal labels label Apr 11, 2023
@captainsafia captainsafia merged commit 06ff899 into main Apr 12, 2023
@captainsafia captainsafia deleted the safia/oai-form-bugfix branch April 12, 2023 02:19
@ghost ghost added this to the 8.0-preview4 milestone Apr 12, 2023
@captainsafia
Copy link
Member Author

/backport to release/7.0

@github-actions
Copy link
Contributor

Started backporting to release/7.0: https://github.com/dotnet/aspnetcore/actions/runs/4684138875

@github-actions
Copy link
Contributor

@captainsafia backporting to release/7.0 failed, the patch most likely resulted in conflicts:

$ git am --3way --ignore-whitespace --keep-non-patch changes.patch

Applying: Don't generate RequestBody for parameters when disabledInferredBody is true
Using index info to reconstruct a base tree...
M	src/OpenApi/src/OpenApiGenerator.cs
M	src/OpenApi/test/OpenApiGeneratorTests.cs
Falling back to patching base and 3-way merge...
Auto-merging src/OpenApi/test/OpenApiGeneratorTests.cs
CONFLICT (content): Merge conflict in src/OpenApi/test/OpenApiGeneratorTests.cs
Auto-merging src/OpenApi/src/OpenApiGenerator.cs
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Don't generate RequestBody for parameters when disabledInferredBody is true
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
Error: The process '/usr/bin/git' failed with exit code 128

Please backport manually!

@github-actions
Copy link
Contributor

@captainsafia an error occurred while backporting to release/7.0, please check the run log for details!

Error: git am failed, most likely due to a merge conflict.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
old-area-web-frameworks-do-not-use *DEPRECATED* This label is deprecated in favor of the area-mvc and area-minimal labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WithOpenApi adds Empty requestBody when parameter is of type string[] or StringValues
2 participants