[2.0] SDL windowing and input #266
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Perksey
changed the title
|
Ready for review, mobile is out of scope for this PR. |
HurricanKai
requested changes
Aug 16, 2020
src/Core/Silk.NET.Core/Miscellaneous/VkNonDispatchableHandle.cs
Outdated
Show resolved
Hide resolved
src/Input/Silk.NET.Input.Common/Internals/InternalsVisibleTo.cs
Outdated
Show resolved
Hide resolved
src/Input/Silk.NET.Input.Common/Internals/ReadOnlyCollectionListAdapter.cs
Show resolved
Hide resolved
src/Windowing/Silk.NET.Windowing.Common/Internals/InternalsVisibleTo.cs
Outdated
Show resolved
Hide resolved
Perksey
commented
Aug 16, 2020
Co-authored-by: HurricanKai <kai.jellinghaus1@gmail.com>
…ure/sdl-windowing
|
First wave of review comments addressed. Generally where I've left code commented out in this PR it's for some sort of illustrative purpose, such as demonstrating what enumerants we don't support in the windowing spec or demostrating what enumerants we haven't used. |
HurricanKai
approved these changes
Aug 16, 2020
|
Thanks for the approval. Don't merge quite yet, as there's still some stuff from #262 I'll have to clean up once that's merged in a couple of secs. |
Perksey
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the PR
Adds a SDL windowing and input backend, as well as completed basic tests of Silk.NET on iOS (with the interpreter enabled) and Android
Related issues, Discord discussions, or proposals
#48
Closes #211
Closes #49
Further Comments
Requirements
Stretch goals
--interpreter