Skip to content

[2.0] New Interop #262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 71 commits into from
Aug 16, 2020
Merged

[2.0] New Interop #262

merged 71 commits into from
Aug 16, 2020

Conversation

HurricanKai
Copy link
Member

@HurricanKai HurricanKai commented Aug 6, 2020 •
edited
Loading

Marshallers to-do:

  • Bool Marshaller
  • Delegate Marshaller
  • Pin Object Marshaller
  • Ref Marshaller
  • Span Marshaller
  • String Marshaller

@HurricanKai HurricanKai requested a review from Perksey as a code owner August 6, 2020 17:46
@HurricanKai
Copy link
Member Author

HurricanKai commented Aug 12, 2020 •
edited
Loading

I believe this version of the generator can do everything we need.

@HurricanKai
Copy link
Member Author

Not sure about these conflicts @Perksey could you have a look at those? Seem to originate from some Binder change?

@Perksey
Copy link
Member

Perksey commented Aug 14, 2020

Can't see them on mobile but when I turn the PC back on I'll merge the latest 2.0 changes and sort out the conflicts.

HurricanKai and others added 20 commits August 16, 2020 15:11
@HurricanKai
Refactorings
154cbba
@HurricanKai
Remove extra Generator reference from OpenGL
99e12a3
@HurricanKai
Always use SymbolDisplayFormat.FullyQualifiedFormat
855e4ac
@Perksey
partial unsafe -> unsafe partial
ceedf4b
@Perksey
partial override -> override partial
773c33e
@HurricanKai
Fully Qualify Parameters and Return Type
2d9c323
@HurricanKai
Revert Debug line
328b516
@HurricanKai
NativeAPIGenerator -> NativeApiGenerator
fcf3849
@HurricanKai
Allow processing of methods without NativeApiAttribute
989302a
@HurricanKai
Allow processing of classes convertible to Silk.NET.Core.Native.Nativ…
efb38b7 
…eApiContainer
@Perksey
Fix everything that was broken, hello SilkTouch <3
9b354ed
@HurricanKai
Add CoreGetSlotCount
9a3b6f0
@HurricanKai
Remove unused usings
4cf5188
@HurricanKai
Fix issues that would appear occasionally
e3d74aa
@Perksey
Change how CoreGetSlotCount works
f71c971
@HurricanKai
Remove more Debug things
a4700e2
@Perksey
Merge remote-tracking branch 'origin/feature/new-interop' into featur…
c31f537 
…e/new-interop
@HurricanKai
Rework Loading backend to use a ConcurrentDictionary instead of an Array
52e10f8
@HurricanKai
PinObjectMarshaller before DelegateMarshaller
82855fb
@HurricanKai
MarshalUtils -> SilkMarshal
7844b0f
Perksey
Perksey reviewed Aug 16, 2020
View reviewed changes
Copy link
Member

@Perksey Perksey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This codebase is brilliant! Just a few more things before I merge (I shall commit fixes for my mistakes for you)

@HurricanKai HurricanKai mentioned this pull request Aug 16, 2020
Merged
6 tasks
@HurricanKai HurricanKai merged commit f106838 into 2.0 Aug 16, 2020
@HurricanKai HurricanKai deleted the feature/new-interop branch August 16, 2020 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Perksey Perksey Perksey approved these changes

Assignees
No one assigned
Labels
area-Core/Infrastructure/Codegen feature New feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HurricanKai @Perksey