[Merged by Bors] - fix new clippy lints #5160
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakobhellermann
added
the
C-Code-Quality
tim-blackbird
approved these changes
Jul 1, 2022
|
it would be better to wait for the new lint to be fixed rather than add an ignore for an unstable lint |
examples/app/custom_loop.rs
Outdated
|
|
||
| struct Input(String); | ||
|
|
||
| fn my_runner(mut app: App) { | ||
| println!("Type stuff into the console"); | ||
| for line in io::stdin().lock().lines() { | ||
| #[allow(clippy::significant_drop_in_scrutinee)] // https://github.com/rust-lang/rust-clippy/issues/8963 |
There was a problem hiding this comment.
I'd prefer to avoid ignoring this for as long as we can.
There was a problem hiding this comment.
I removed the ignore.
There was a problem hiding this comment.
The PR still contains the change
- use std::io::BufRead;
- for line in io::stdin().lock().lines() {
+ for line in io::stdin().lines() { which was stabilized in 1.62 and has an equivalent implementation https://doc.rust-lang.org/stable/std/io/struct.Stdin.html#method.lines.
I can revert the change if it shouldn't be in this clippy fix PR.
There was a problem hiding this comment.
I'm fine with this change being included.
alice-i-cecile
requested changes
Jul 1, 2022
alice-i-cecile
approved these changes
Jul 1, 2022
alice-i-cecile
added
the
S-Ready-For-Final-Review
ManevilleF
approved these changes
Jul 1, 2022
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Jul 1, 2022
# Objective - Nightly clippy lints should be fixed before they get stable and break CI ## Solution - fix new clippy lints - ignore `significant_drop_in_scrutinee` since it isn't relevant in our loop rust-lang/rust-clippy#8987 ```rust for line in io::stdin().lines() { ... } ``` Co-authored-by: Jakob Hellermann <hellermann@sipgate.de>
inodentry
pushed a commit
to IyesGames/bevy
that referenced
this pull request
Aug 8, 2022
# Objective - Nightly clippy lints should be fixed before they get stable and break CI ## Solution - fix new clippy lints - ignore `significant_drop_in_scrutinee` since it isn't relevant in our loop rust-lang/rust-clippy#8987 ```rust for line in io::stdin().lines() { ... } ``` Co-authored-by: Jakob Hellermann <hellermann@sipgate.de>
james7132
pushed a commit
to james7132/bevy
that referenced
this pull request
Oct 28, 2022
# Objective - Nightly clippy lints should be fixed before they get stable and break CI ## Solution - fix new clippy lints - ignore `significant_drop_in_scrutinee` since it isn't relevant in our loop rust-lang/rust-clippy#8987 ```rust for line in io::stdin().lines() { ... } ``` Co-authored-by: Jakob Hellermann <hellermann@sipgate.de>
ItsDoot
pushed a commit
to ItsDoot/bevy
that referenced
this pull request
Feb 1, 2023
# Objective - Nightly clippy lints should be fixed before they get stable and break CI ## Solution - fix new clippy lints - ignore `significant_drop_in_scrutinee` since it isn't relevant in our loop rust-lang/rust-clippy#8987 ```rust for line in io::stdin().lines() { ... } ``` Co-authored-by: Jakob Hellermann <hellermann@sipgate.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Solution
significant_drop_in_scrutineesince it isn't relevant in our loop significant_drop_in_scrutinee is confusing and not very useful for for loops rust-lang/rust-clippy#8987