Text background colors #18892
Merged
Text background colors #18892
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ickshonpe
added
C-Feature
Olle-Lukowski
approved these changes
Apr 22, 2025
Co-authored-by: Olle Lukowski <lukowskiolle@gmail.com>
Olle-Lukowski
approved these changes
Apr 22, 2025
Henauxg
approved these changes
Apr 23, 2025
There was a problem hiding this comment.
I'm not very familiar with render entity extraction so my review of extract_text_background_colors was pretty basic.
In queue_text, we could optionally move the computation of section_rects in the already existing main glyphs loop to avoid having a second linear scan of all the glyphs.
Co-authored-by: Gilles Henaux <ghx_github_priv@fastmail.com>
ickshonpe
added
S-Ready-For-Final-Review
ickshonpe
added
the
M-Needs-Release-Note
NthTensor
approved these changes
Apr 27, 2025
mockersf
approved these changes
May 4, 2025
andrewzhurov
pushed a commit
to andrewzhurov/bevy
that referenced
this pull request
May 17, 2025
# Objective Add background colors for text. Fixes bevyengine#18889 ## Solution New component `TextBackgroundColor`, add it to any UI `Text` or `TextSpan` entity to add a background color to its text. New field on `TextLayoutInfo` `section_rects` holds the list of bounding rects for each text section. The bounding rects are generated in `TextPipeline::queue_text` during text layout, `extract_text_background_colors` extracts the colored background rects for rendering. Didn't include `Text2d` support because of z-order issues. The section rects can also be used to implement interactions targeting individual text sections. ## Testing Includes a basic example that can be used for testing: ``` cargo run --example text_background_colors ``` --- ## Showcase  Using a proportional font with kerning the results aren't so tidy (since the bounds of adjacent glyphs can overlap) but it still works fine:  --------- Co-authored-by: Olle Lukowski <lukowskiolle@gmail.com> Co-authored-by: Gilles Henaux <ghx_github_priv@fastmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Add background colors for text.
Fixes #18889
Solution
New component
TextBackgroundColor, add it to any UITextorTextSpanentity to add a background color to its text.New field on
TextLayoutInfosection_rectsholds the list of bounding rects for each text section.The bounding rects are generated in
TextPipeline::queue_textduring text layout,extract_text_background_colorsextracts the colored background rects for rendering.Didn't include
Text2dsupport because of z-order issues.The section rects can also be used to implement interactions targeting individual text sections.
Testing
Includes a basic example that can be used for testing:
Showcase
Using a proportional font with kerning the results aren't so tidy (since the bounds of adjacent glyphs can overlap) but it still works fine: