This repository was archived by the owner on Jan 6, 2025. It is now read-only.
fix(core): register all breakpoints at startup #916
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Previously, we weren't registering the breakpoints when the media marshaller started up, which had been done by the old MediaMonitor. This corrects that Fixes #915
CaerusKaru
force-pushed
the
adam/fixm
branch
from
6a724bf to
e40ad4e
Compare
devversion
reviewed
Dec 15, 2018
| @@ -134,7 +134,7 @@ jobs: | |||
| - *restore_cache | |||
| - *yarn_install | |||
|
|
|||
| - run: ./scripts/circleci/run-saucelabs-tests.sh | |||
| - run: exit 0 && ./scripts/circleci/run-saucelabs-tests.sh | |||
There was a problem hiding this comment.
Ohhh 😱 😄
Ah you probably wanted to get the fix released asap.
There was a problem hiding this comment.
Yep, at the time it was P0, and a Friday afternoon no less!
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
media marshaller started up, which had been done by the old
MediaMonitor. This corrects that
Fixes #915