-
Notifications
You must be signed in to change notification settings - Fork 768
fxHide.lt-md (and others) is broken in 7.0.0-beta.20 #915
Comments
@cfeltz34 I'm working on this right now and we'll get a patch release out by EOD. This is just for |
Yes. Also would like to point out that I'm not crazy! :) |
Also seeing this with "fxLayoutGap.gt-sm" |
@jefbarn Yeah that tracks. I'm hunting down the fix now. |
* Previously, we weren't registering the breakpoints when the media marshaller started up, which had been done by the old MediaMonitor. This corrects that Fixes #915
Here's the fix: #916 |
* Previously, we weren't registering the breakpoints when the media marshaller started up, which had been done by the old MediaMonitor. This corrects that Fixes #915
* Previously, we weren't registering the breakpoints when the media marshaller started up, which had been done by the old MediaMonitor. This corrects that by registering the breakpoints in the marshaller Fixes #915
If anyone could test that it works using the nightly builds ( |
7.0.0-beta.21 has been released to address this issue |
Hi,
I have updated my projet with 7.0.0-beta.21 but... same problem :-(
-->
https://stackblitz.com/edit/angular-piagbq?file=src%2Fapp%2Fapp.component.html
[image: image.png]
Le sam. 15 déc. 2018 à 01:48, CaerusKaru <notifications@github.com> a
écrit :7.0.0-beta.21 has been released to address this issue
… —
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#915 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ArwpjjNZRugVD627jRVjk4qZtT4GzDb-ks5u5Eb1gaJpZM4ZUUKs>
.
|
Can confirm that beta.21 is not working. For example this:
Stackblitz: https://stackblitz.com/edit/angular-3fnkgk |
I know this is an incredibly urgent issue, but at the moment I'm at a loss. The patch in 7.0.0-beta.21 added a test for this case explicitly, which is passing. I'm still actively working on this, and we'll try to get a patch by next week. |
The plot thickens as this exact template on our demo-app (which is built and compiled with the Angular CLI) works as expected. Now the question is why doesn't this work on StackBlitz? (or other apps if this isn't working for people using the CLI) |
It is not only on StackBlitz.
I have exactly the same issues in my computer (New project created with the
CLI)
Le sam. 15 déc. 2018 22:24, CaerusKaru <notifications@github.com> a écrit :
… The plot thickens as this exact template on our demo-app (which is built
and compiled with the Angular CLI) works as expected. Now the question is
why doesn't this work on StackBlitz? (or other apps if this isn't working
for people using the CLI)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#915 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/Arwpjn0Isoc2tTQpOi6h4EfNyFaUVGFMks5u5Wh8gaJpZM4ZUUKs>
.
|
@cfeltz34 I believe you! It's just so bizarre that our demo app works flawlessly with the same build artifacts. |
I'm newbie on Angular, but I have some experience on javascript and object
programming.
It's late here, in France, but I will try to have a look tomorrow to give
you more informations
Le sam. 15 déc. 2018 22:34, CaerusKaru <notifications@github.com> a écrit :
… @cfeltz34 <https://github.com/cfeltz34> I believe you! It's just so
bizarre that our demo app works flawlessly with the same build artifacts.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#915 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ArwpjreSaInOP7-oH7u1NEZ_AKNhf_84ks5u5Wr8gaJpZM4ZUUKs>
.
|
I tracked it down! And just when I thought I was losing the last remnants of my sanity. The issue with our demo app is that we have an |
This was an unbelievable PITA, but turned out to be super simple. There was a race condition in the new If it's urgent, you can use the nightly builds once it's been merged. |
@cfeltz34 Can you test this in your app? Please install the new version with |
Anecdotally with the StackBlitz provided, installing the latest nightly (enter |
@CaerusKaru Can confirm, it's working in my stackblitz, too :) |
Great's!
It's work on Stackblitz :-)
But I have some difficulties to test in my platform.
I jave uninstalled "npm uninstall @angular/flex-layout" and installed your
branch "npm i angular/flex-layout" but my project can't find the module.
I have tested with :
- [ts] Cannot find module 'angular/flex-layout'. [2307]
- [ts] Cannot find module '@angular/flex-layout'. [2307]
I can wait the next version, it's not problem for me. But I sorry if I can
test your fix.
Thank !
Christophe Feltz
Ingénieur en développement Informatique
Responsable bénévole des projets :
- la carte des dons : https://www.lacartedesdons.fr
- PermaGuildes : https://www.permaguildes.fr/
- Comment sortir, la carte des randonneurs : https://map.commentsortir.fr/
- Infor'ma Planète (http://www.informaplanete.org)
Blog of my travels : http://cfeltz.blogspot.com
--
Tél : (+33) 6 60 17 25 11
105 avenue de la Méditerranée
34 970 Lattes (France)
Le dim. 16 déc. 2018 à 09:17, Paul Stelzer <notifications@github.com> a
écrit :
… @CaerusKaru <https://github.com/CaerusKaru> Can confirm, it's workin in
my stackblitz, too :)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#915 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/Arwpjnck2be_2e5rEvxIt2qm4FgH0BX3ks5u5gGcgaJpZM4ZUUKs>
.
|
Combine Uses of https://github.com/angular/flex-layout/blob/master/docs/documentation/fxShow-API.md Env: @angular/core : 7.1.3 , angular/flex-layout: ^7.0.0-beta.21 <div fxHide fxShow.gt-sm>test</div> |
Should fixed with beta.22 - or revert back to beta.19 if you cannot wait until the new beta release |
I had the same issue, I can confirm that this issue is fixed with beta.22. |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Bug Report
What is the expected behavior?
When I use "fxHide.lt-md" attribute in a Angular project 7.x the component need to be hidden
What is the current behavior?
"fxHide" attribute hide the component
"fxHide.lt-md" attribute not hide the component with Angular 7.x
"fxHide.lt-md" attribute hide the component with Angular 5.4
What are the steps to reproduce?
https://stackblitz.com/edit/angular-piagbq?file=src%2Fapp%2Fapp.component.html
Which versions of Angular, Material, OS, TypeScript, browsers are affected?
Angular 7.0.1 on Windows + Chrome (Version 70.0.3538.110 (Build officiel))
The text was updated successfully, but these errors were encountered: