This repository was archived by the owner on Jan 6, 2025. It is now read-only.
refactor: migrate ObservableMedia to MediaObserver #892
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is blocked (only technically) on #888 |
|
@CaerusKaru - can you rebase this? |
CaerusKaru
force-pushed
the
adam/media-observer
branch
from
13c1309 to
38d5a8f
Compare
CaerusKaru
force-pushed
the
adam/media-observer
branch
from
38d5a8f to
9f47c7a
Compare
|
@ThomasBurleson done. |
ThomasBurleson
force-pushed
the
adam/media-observer
branch
from
9f47c7a to
25210b4
Compare
ThomasBurleson
added
pr: lgtm
BREAKING CHANGE: `ObservableMedia` is now deprecated in anticipation of RxJS v7. The new API is called **`MediaObserver`**, and provides the exact same functionality as ObservableMedia, except you cannot directly subscribe to it, You can subscribe to MediaObserver's `media$` property; in place of subscribing directly to ObservableMedia. Fixes #885.
ThomasBurleson
force-pushed
the
adam/media-observer
branch
from
25210b4 to
bde1cff
Compare
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE:
ObservableMediais now deprecated in anticipation of RxJS v7. The new API is calledMediaObserver, and provides the exact same functionality asObservableMedia, except you cannot directly subscribe to itMediaObserver'smedia$property in place of subscribing directly toObservableMediaFixes #885