This repository was archived by the owner on Jan 6, 2025. It is now read-only.
GENERAL NOTICE: changes to ObservableMedia #885
Labels
discussion
Further discussion with the team is needed before proceeding
Comments
CaerusKaru
added
the
discussion
|
I really like the CDK BreakpointObserver.. except that id does not contain "Window" Breakpoint Range from https://material.io/design/layout/responsive-layout-grid.html#breakpoints It that could be added it would be super awesome! :) |
|
@CaerusKaru I can't find any info on RxJS v7. Can you link us to the change you're talking about? |
|
See here for the design doc |
ThomasBurleson
pushed a commit
that referenced
this issue
Nov 30, 2018
BREAKING CHANGE: `ObservableMedia` is now deprecated in anticipation of RxJS v7. The new API is called **`MediaObserver`**, and provides the exact same functionality as ObservableMedia, except you cannot directly subscribe to it, You can subscribe to MediaObserver's `media$` property; in place of subscribing directly to ObservableMedia. Fixes #885.
ThomasBurleson
pushed a commit
that referenced
this issue
Nov 30, 2018
BREAKING CHANGE: `ObservableMedia` is now deprecated in anticipation of RxJS v7. The new API is called **`MediaObserver`**, and provides the exact same functionality as ObservableMedia, except you cannot directly subscribe to it, You can subscribe to MediaObserver's `media$` property; in place of subscribing directly to ObservableMedia. Fixes #885.
ThomasBurleson
pushed a commit
that referenced
this issue
Nov 30, 2018
BREAKING CHANGE: `ObservableMedia` is now deprecated in anticipation of RxJS v7. The new API is called **`MediaObserver`**, and provides the exact same functionality as ObservableMedia, except you cannot directly subscribe to it, You can subscribe to MediaObserver's `media$` property; in place of subscribing directly to ObservableMedia. Fixes #885.
liwde
added a commit
to Aam-Digital/ndb-core
that referenced
this issue
Jan 14, 2019
There was an undocumented breaking change. See: angular/flex-layout#885 angular/flex-layout@1205588#diff-9caf78031951b821123260bf7bc8e031
liwde
pushed a commit
to Aam-Digital/ndb-core
that referenced
this issue
Jan 17, 2019
* updated the deprecated HttpModule to HttpClientModule * removed deprecated RxJS 6 features and rxjs-compat * updated dependencies (doesn't compile; some dependency is using typescript 3.2.2) * further dependency updates and fixes for breaking changes see #187 * remove "typings" dependency. unneeded as we are using @types * fixed lint errors * Update some more dependencies and fix breaking change in flex-layout There was an undocumented breaking change. See: angular/flex-layout#885 angular/flex-layout@1205588#diff-9caf78031951b821123260bf7bc8e031
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Due to the impending changes to RxJS in v7, there will be some changes made to
ObservableMedia. This is because in the next version, RxJS no longer allows extending ofObservable(since it's being changed to a function instead of a class).One option we will explore is simply migrating to the CDK's
BreakpointObserver. Another will be wrapping the observable in another class (possibly still calledObservableMediajust with a different way of accessing theObservable).This notice is as much open for discussion as it is for getting the news out there. RxJS v7 is still a ways away, but the earlier we plan and explore options, the better the user experience for everyone.
The text was updated successfully, but these errors were encountered: