Add the type of service when executing 'call_service' #282
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We want to reuse the roslibjs as the front-end JavaScript library by leveraging the ros2-web-bridge in ROS2. But the current roslibjs doesn't transmit the service type when calling a service, which is a necessary element when sending the request in ROS2. This patch adds this information to make it compatible with ROS2.
|
Hi @jihoonl, When I was developing the ros2-web-bridge, I found this problem. Although I had a very tricky workaround, which lets the code odd, I think it would better change the library. I am not sure whether it's proper to do it in order to make roslibjs workable in ROS2, so please help me review this patch. I hope the roslibjs can be reused in ROS2 by adopting some minor changes. Thanks! |
jihoonl
approved these changes
Mar 24, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to reuse the roslibjs as the front-end JavaScript library by
leveraging the ros2-web-bridge in ROS2. But the current roslibjs doesn't
transmit the service type when calling a service, which is a necessary
element when sending the request in ROS2.
This patch adds this information to make it compatible with ROS2.