add type to call_service protocol #656
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Are you documenting a feature that rosbridge already has, or requesting this to be implemented? |
| @@ -23,7 +23,7 @@ This project is released as part of the [Robot Web Tools](http://robotwebtools.o | |||
|
|
|||
| A rosbridge client is a program that communicates with rosbridge using its JSON API. rosbridge clients include: | |||
|
|
|||
| * [roslibjs](https://github.com/RobotWebTools/roslibjs) - A JavaScript API, which communicates with rosbridge over WebSockets. | |||
| * [roslibjs](https://github.com/apiyap/roslibjs) - A JavaScript API, which communicates with rosbridge over WebSockets. | |||
|
Hi - please respond to above comments, and feel free to open another PR when you're ready. Thanks! |
|
It appears that this was added to roslibjs in RobotWebTools/roslibjs#282 to be operable with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Public API Changes
For compatibility with roslibjs
https://github.com/RobotWebTools/roslibjs/blob/develop/src/core/Service.js#L62
and for ROS2(foxy) need type for create rcl_client_init
Description