Fix #222: Prompt functions hang in editor commands #230
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change fixes an issue where $host.UI prompt functions do not return the user's response when run inside of PowerShell editor commands. This was caused by the HandleInvokeExtensionCommand method returning a Task that did not complete until after the command completed. The fix was to not await on completion of the command so that the prompt response has a chance to come through.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes an issue where $host.UI prompt functions do not return
the user's response when run inside of PowerShell editor commands. This
was caused by the HandleInvokeExtensionCommand method returning a Task
that did not complete until after the command completed. The fix was to
not await on completion of the command so that the prompt response has a
chance to come through.
This change is