Skip to content

Editor Commands are not receiving $host.ui.PromptForChoice output #222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gerane opened this issue May 13, 2016 · 8 comments
Closed

Editor Commands are not receiving $host.ui.PromptForChoice output #222

gerane opened this issue May 13, 2016 · 8 comments
Labels
Issue-Bug A bug to squash.
Milestone

Comments

@gerane
Copy link
Contributor

gerane commented May 13, 2016

https://gist.github.com/gerane/1925324d7ea7e3c767eb45abcde91e8b

The above is an example. The output shows the prompt times out and never gets the selection selected by the user. It works when running via f8.

David said he was able to reproduce.

@daviwil
Copy link
Contributor

daviwil commented May 13, 2016

Yep, will be looking into this. Something is causing the choice result to not be received when PromptForChoice is run inside of an editor command.

@daviwil daviwil added the Issue-Bug A bug to squash. label May 13, 2016
@daviwil daviwil modified the milestones: Backlog, 0.6.1 May 13, 2016
daviwil added a commit that referenced this issue May 16, 2016
Fix #222: Prompt functions hang in editor commands
@daviwil
Copy link
Contributor

daviwil commented May 16, 2016

Done ;)

@gerane
Copy link
Contributor Author

gerane commented May 16, 2016

Sweet. When is the next update getting pushed out?
On May 16, 2016 4:39 PM, "David Wilson" notifications@github.com wrote:

Done ;)


You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
#222 (comment)

@daviwil
Copy link
Contributor

daviwil commented May 16, 2016

Trying to make it happen, waiting on binary signing to be approved... If not today then tomorrow morning

@gerane
Copy link
Contributor Author

gerane commented May 16, 2016

Sweet!

On Mon, May 16, 2016, 6:28 PM David Wilson notifications@github.com wrote:

Trying to make it happen, waiting on binary signing to be approved... If
not today then tomorrow morning


You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
#222 (comment)

@daviwil
Copy link
Contributor

daviwil commented May 16, 2016

Shipped!

@gerane
Copy link
Contributor Author

gerane commented May 16, 2016

You are the man. Irwin has competition.
On May 16, 2016 6:49 PM, "David Wilson" notifications@github.com wrote:

Shipped!


You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
#222 (comment)

@daviwil
Copy link
Contributor

daviwil commented May 16, 2016

Haha, I don't know that I can compete on his level

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Bug A bug to squash.
Projects
None yet
Development

No branches or pull requests

2 participants