-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
[OO] Allow slashes in citation keys for reference marks #12961
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: subhramit <subhramit.bb@live.in>
Signed-off-by: subhramit <subhramit.bb@live.in>
Signed-off-by: subhramit <subhramit.bb@live.in>
Signed-off-by: subhramit <subhramit.bb@live.in>
@trag-bot didn't find any issues in the code! ✅✨ |
I tried to find some documentation on what characters are allowed in the citation key, but unfortunately i dont see that the biblatex doc provides any information about that. |
Backslash is used for escaping. I think the key field is treated like the other fields as well regarding the characters |
This one is a forward slash |
May need a third opinion to finalize this. |
I bet they are allowed. I need to try out with a minimal .tex and .bib file. - This file should be committed to the repo. Nearby the IEEE.tex. (I'm on mobile writing a quick answer. As soon as I am on the PC, I can craft such files and tests) |
I tried generating some using Claude. You can merge the commit and test when convenient. |
I will create a new repository with.tex and .bib files with a separate CI Pipeline. |
Cant test the next days |
Future work: use logic of jabref logic for making valid citation keys maybe? |
Follow-up to #12474
To accommodate the following auto-generated default citation key from the bibtex entry mentioned in #12930 (comment):
[contains forward slashes("
/
")]Earlier behavior: The key would not be parsed properly as it was not flexible enough to allow slashes. After citation, on trying to generate bibliography, following dialog was observed:
And then the exception:
Mandatory checks
CHANGELOG.md
described in a way that is understandable for the average user (if change is visible to the user)