CSL-based preview does not respect curly braces at author

[Siedlerchr]

JabRef version

6.0-alpha

Operating system

macOS

Details on version and operating system

mac os 15.5

Checked with the latest development build (copy version output from About dialog)

• I made a backup of my libraries before testing the latest development version.
• I have tested the latest development version and the problem persists

Steps to reproduce the behaviour

1. Create a new entry with the following bibtex data (paste it to the main table)

@Online{,
  author = {{The PGF/TikZ Team}},
  date   = {2023-01-16},
  title  = {pgf – Create PostScript and PDF graphics in TeX},
  url    = {https://ctan.org/pkg/pgf},
}

2. Under File -> Preferences -> Entry preview at IEEE style after JabRef's custom style

3. Toggle between the style int he preview tab and notice the difference

JabRef style (correct):

CSL Style incorrect:

Classes to look at:
JabRefItemDataProvider

Appendix

...

Log File

Paste an excerpt of your log file here

[priyanshu16095]

/assign-me

[subhramit]

Unable to reproduce:

[koppor]

@subhramit The screenshot exactly shows that it is ignored :) -- When author is enclosed in curly braces, it needs to be reproduced in verbatim - and not transformed

Example:

author = {Oliver Kopp}

is then

O. Kopp

and

author = {{Oliver Kopp}}

is then

Oliver Kopp

[subhramit]

My thoughts:
Since we use citeproc for both previews and LO, this issue should exist on LO too (and it does).
Treating citeproc as a black box (X):

1. X->String output. We don't know where authors are in this string (for different styles), so definitive post-processing will not be possible.
2. Entry->X. I tried to put an additional pair of curly braces and check - the result is unchanged. That means X has some internal mechanism of stripping off the curly braces, so pre-processing is also useless (?). JabRef probably already pre-processes the author field correctly as it is correctly treated in JabRef's custom preview style.

However, I am not sure if we use the same author pre-processing pipeline for both CSL and other styles - that could make a difference (although in LO CSL we use the bibentry as it is).
This is either a good first issue, or depends on citeproc.

[Siedlerchr]

We do preprocessing for CSL: Could be the latex2unicode formatter which is the problem
Refs https://github.com/JabRef/jabref-issue-melting-pot/issues/386

jabref/src/main/java/org/jabref/logic/citationstyle/JabRefItemDataProvider.java

Lines 159 to 171 in 67e25a0

	for (Field key : fields) {
	bibEntry.getResolvedFieldOrAlias(key, bibDatabaseContext.getDatabase())
	.map(removeNewlinesFormatter::format)
	.map(LatexToUnicodeAdapter::format)
	.ifPresent(value -> {
	if (StandardField.MONTH == key) {
	// Change month from #mon# to mon because CSL does not support the former format
	value = bibEntry.getMonth().map(Month::getShortName).orElse(value);
	}
	bibTeXEntry.addField(new Key(key.getName()), new DigitStringValue(value));
	});
	}
	return BIBTEX_CONVERTER.toItemData(bibTeXEntry);

For MsOffice we had a similar situation where we needed to re-add them

jabref/src/main/java/org/jabref/logic/msbib/MSBibConverter.java

Lines 127 to 143 in c93a47c

	List<MsBibAuthor> result = new ArrayList<>();
	// Only one corporate author is supported
	// Heuristics: If the author is surrounded by curly braces, it is a corporate author
	boolean corporate = !REMOVE_BRACES_FORMATTER.format(authors).equals(authors);
	Optional<String> authorLatexFreeOpt = entry.getFieldLatexFree(field);
	if (authorLatexFreeOpt.isEmpty()) {
	return result;
	}
	String authorLatexFree = authorLatexFreeOpt.get();
	// We re-add the curly braces to keep the corporate author as is.
	// See https://github.com/JabRef/jabref-issue-melting-pot/issues/386 for details
	if (corporate) {
	authorLatexFree = "{" + authorLatexFree + "}";
	}

[subhramit]

I did not mean to be assigned 🤧
/unassign-me

[priyanshu16095]

@subhramit You can take it, I'll focus on my remaining PRs.

[priyanshu16095]

/unassign-me

[subhramit]

The un-assign action seems to not work.
Either way, I am not taking this, so feel free.

[subhramit]

/assign @priyanshu16095

(I saw above that you were not assigned properly).

[github-actions]

👋 Hey @priyanshu16095, thank you for your interest in this issue! 🎉

We're excited to have you on board. Start by exploring our Contributing guidelines, and don't forget to check out our workspace setup guidelines to get started smoothly.

In case you encounter failing tests during development, please check our developer FAQs!

Having any questions or issues? Feel free to ask here on GitHub. Need help setting up your local workspace? Join the conversation on JabRef's Gitter chat. And don't hesitate to open a (draft) pull request early on to show the direction it is heading towards. This way, you will receive valuable feedback.

Happy coding! 🚀

[koppor]

Tracking of the assingment case:

• The assing-command at CSL-based preview does not respect curly braces at author #12930 (comment) lead to Validation Failed: {"message":"The listed users cannot be searched either because the users do not exist or you do not have permission to view the users.","resource":"Search","field":"q","code":"invalid"} https://github.com/JabRef/jabref/actions/runs/14431880600 - reported at Switch to GitHub "advanced" search takanome-dev/assign-issue-action#302
• The link to a comment of the PR [OO] Allow slashes in citation keys for reference marks #12961 was interpreted as full issue link (now fixed - 3ac0b55). We automatically assign the worker of a PR to the issue. We add the person to the isuse (

  jabref/.github/workflows/on-pr-opened-updated.yml

  Line 113 in 3ac0b55

  UPDATED_ASSIGNEES=$(echo "$ASSIGNEES" | jq --arg new "${{ github.event.pull_request.user.login }}" '. + [$new]')

  ).
• /unassign-me at CSL-based preview does not respect curly braces at author #12930 (comment) was not respected by the action, because of "🤖 Ignoring comment because it's either a quoted reply or a maintainer using self-assignment commands" -- https://github.com/JabRef/jabref/actions/runs/14534607508/job/40780510672
• /unassign-me at CSL-based preview does not respect curly braces at author #12930 (comment) did not work, because of (correctly) " 🤖 Commenter is different from the assignee, ignoring..." (https://github.com/JabRef/jabref/actions/runs/14534658407/job/40780655085)

[priyanshu16095]

This is a good first issue but, I took it with the intention of learning more about CSL or similar things, as I am also new to this.
Thank you for assigning to me.

[subhramit]

This is either a good first issue, or depends on citeproc.

Refs. michel-kraemer/citeproc-java#103

I do not think this is solvable from our end.

[subhramit]

I have filed an upstream PR. Lets see what happens.

[subhramit]

@priyanshu16095 sorry, this ended up being more involved than initially assumed. This needed a fix at the citeproc-java library that we use, and not in JabRef.
Apologies for any time wasted. Please feel free to take other issues or work on the existing ones assigned to you.

[subhramit]

Un-assigning and adding depends-on-external.
/unassign @priyanshu16095

[subhramit]

I have filed an upstream PR. Lets see what happens.

Merged, will be fixed in the next version of citeproc.