Skip to content

Add support for Sapling Extended Full Viewing Keys #1741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 4 commits into
base: dev
Choose a base branch
from

Conversation

dorianvp
Copy link
Member

No description provided.

@dorianvp dorianvp linked an issue Apr 11, 2025 that may be closed by this pull request
@Oscar-Pepper
Copy link
Contributor

i believe this is the wrong approach. zingolib already supports sapling extended full viewing keys as they can converted to diversable FVK via the from implemention. UFVKs can be constructed with only the sapling diversable FVKs (orchard and transparent are optional). consumers of zingolib should convert their key material to UFVKs and create the LightWallet with those

@zancas
Copy link
Member

zancas commented Apr 30, 2025

Hi @dorianvp what do you think?

@Oscar-Pepper
Copy link
Contributor

i didnt realise this was to serve a zingo-cli feature request. I suppose it doesnt hurt to also accept sapling FVKs as an additional feature rather than adding this logic to zingo-cli and it essentially being duplicated for other consumers

@zancas
Copy link
Member

zancas commented May 1, 2025

@Oscar-Pepper or @dorianvp can we update this feature with latest dev?

Is this PR review-ready?

@dorianvp
Copy link
Member Author

dorianvp commented May 1, 2025

No, it's far from ready. It only contains the initial structs to support that feature.

@zancas
Copy link
Member

zancas commented May 6, 2025

Do we still intend to implement this feature?

@dorianvp
Copy link
Member Author

dorianvp commented May 6, 2025

I think we should tag it as low priority.

@dorianvp dorianvp added the lower priority this PR is not the highest priority for the author label May 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lower priority this PR is not the highest priority for the author
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for Sapling Extended FVKs
3 participants