-
Notifications
You must be signed in to change notification settings - Fork 26
Add support for Sapling Extended Full Viewing Keys #1741
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
i believe this is the wrong approach. zingolib already supports sapling extended full viewing keys as they can converted to diversable FVK via the from implemention. UFVKs can be constructed with only the sapling diversable FVKs (orchard and transparent are optional). consumers of zingolib should convert their key material to UFVKs and create the LightWallet with those |
Hi @dorianvp what do you think? |
i didnt realise this was to serve a zingo-cli feature request. I suppose it doesnt hurt to also accept sapling FVKs as an additional feature rather than adding this logic to zingo-cli and it essentially being duplicated for other consumers |
@Oscar-Pepper or @dorianvp can we update this feature with latest dev? Is this PR review-ready? |
No, it's far from ready. It only contains the initial structs to support that feature. |
Do we still intend to implement this feature? |
I think we should tag it as low priority. |
No description provided.