Support donation addresses for light wallet servers #1660
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 17, 2025
|
Simplified PR, this is blocked until this commit is cherry-picked into Zingo Labs' LRZ fork: (or no longer forked) |
|
As far as I can tell zingolib no longer depends on an LRZ fork, is this PR review ready? |
|
Almost, now we are waiting on an LRZ release that contains the change adding support for donation addresses, then it will be time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggestion: Rather than pointing zingolib to a tag on a librustzcash fork ("zcash_client_sqlite-0.12.1_plus_zingolabs_changes-test_2"), can you create a branch so that contributions can be merged into zainolabs' fork? See the Cargo.toml in this pull for an example. Once this is done I can update this PR to point back at the zingolabs fork of LRZ.
Light wallet servers will soon be advertising Zcash donation addresses via their LightdInfo gRPC endpoints, this patch to zingolib allows its dependent projects to support it.
Related PRs: