Use new process API for starting language servers

[vitallium]

Use new process API for starting language servers

Improve initial developer experience of the Ruby extension by utilizing the new Process API for starting language servers.

Key points:

• The Ruby extension always should prefer LSPs available in project gemset.
• The binary.path option acts as a circuit breaker in the activation logic for experienced users and for debugging purposes.

Test cases

All test cases and current activation logic:

1. If an absolute path lsp.<LSP_NAME>.binary.path is available, ignore the use_bundler configuration option value and use the provided path.
2. If the use_bundler configuration option is true:
   1. Start an LSP with bundle exec. In most cases, this will activate the version available in the project's gemset.
3. If the use_bundler configuration option is false:
4. Check the project's gemset to see if the LSP is available there. See below.
5. If available, use it.
6. Otherwise, check the extension's work dir for the installed LSP.
7. Check for updates.
8. Start the isolated LSP installed in the extension's work dir.

graph TD;
    A[Start] --> B{Absolute path 'binary.path' available?}
    B -->|Yes| C[Use the provided path]
    B -->|No| D{Is 'use_bundler' configuration option true?}
    D -->|Yes| E[Start LSP with bundler]
    D -->|No| G[Check the project's gemset for LSP]
    G --> H{Is LSP available in gemset?}
    H -->|Yes| I[Use the available LSP]
    H -->|No| J[Check the extension's work dir for installed LSP]
    J --> K{Check for updates}
    K --> L[Start isolated LSP in extension's work dir]
    C --> End[End]
    I --> End
    L --> End

Loading

solargraph (default)

• Gem name: solargraph
• Uses bundler by default: true

Demo

Using solargraph from the project' gemset:

solargraph_extension_gemset.mp4

Using solargraph from the extenion' gemset:

solargraph_project_gemset.mp4

ruby-lsp

• Gem name: ruby-lsp
• Uses bundler by default: false

rubocop

• Gem name: rubocop
• Uses bundler by default: true

TODO

• Cover newly added functionality with tests
• Test all supported LSPs
• Edge cases?

Resources

• Introducing the use_bundler configuration option

[orangewolf]

excited about this =-) thanks for working on it