Fix nan encoding in consolidated metadata #2996
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
needs release notes
d-v-b
reviewed
Apr 17, 2025
Co-authored-by: Davis Bennett <davis.v.bennett@gmail.com>
github-actions
bot
removed
the
needs release notes
TomAugspurger
approved these changes
Apr 18, 2025
There was a problem hiding this comment.
I do wonder if something like #2144 would mean we don't need this workaround, but this looks good for now.
d-v-b
added a commit
to d-v-b/zarr-python
that referenced
this pull request
Apr 20, 2025
* Fix nan encoding in consolidated metadata Co-authored-by: Davis Bennett <davis.v.bennett@gmail.com>
d-v-b
reviewed
Apr 28, 2025
| @@ -355,10 +355,10 @@ def to_buffer_dict(self, prototype: BufferPrototype) -> dict[str, Buffer]: | |||
| assert isinstance(consolidated_metadata, dict) | |||
| for k, v in consolidated_metadata.items(): | |||
| attrs = v.pop("attributes", None) | |||
| d[f"{k}/{ZATTRS_JSON}"] = attrs | |||
| d[f"{k}/{ZATTRS_JSON}"] = _replace_special_floats(attrs) | |||
There was a problem hiding this comment.
@mpiannucci was this particular change important? Given that the "special floats" logic is very narrowly scoped to array metadata, I don't think we want to apply it to the attributes.
I'm just seeing this now as I adapt #2874 to the latest changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2990 by reusing the special character replacement before encoding the same as the v3 metadata does
TODO:
docs/user-guide/*.rstchanges/