Add a test with up to date dependencies & fix zarr-python v2 #2973
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good news, the new CI job fails as expected. |
|
🎉 and with the correct numcodecs pin, the latest deps job passes now. |
dstansby
changed the title
|
Going to self merge and do a release to unbreak v2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently on the v2 branch the dependencies in the test are pinned in
requirements_*.txtfiles at the root of the repository, and these pins are bumped by dependabot periodically (I think weekly?). This means when a new version of a dependency is released, there is a period where we don't test against it. This prevents us from catching issues such as in #2965.This PR adds a new workflow that creates a fresh conda environment, then pip installs
zarr-python. This emulates how a user installs, and will automatically pick up the latest versions of dependencies.Hopefully this will initially fail, because it will pull in
numcodecs0.16. Then I plan to introduce the (correct...) pin, and hopefully that will fix the new test.EDIT: everything seems to have worked, so I think this is good to review