Enhanced object literals don't have arrows #51
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a bug in serializeFunc
|
If you prefer a single commit, I can rework things |
okuryu
reviewed
Jul 28, 2019
index.js
Outdated
| @@ -12,6 +12,7 @@ var PLACE_HOLDER_REGEXP = new RegExp('"@__(F|R|D|M|S)-' + UID + '-(\\d+)__@"', ' | |||
|
|
|||
| var IS_NATIVE_CODE_REGEXP = /\{\s*\[native code\]\s*\}/g; | |||
| var IS_PURE_FUNCTION = /function.*?\(/; | |||
| var IS_ARROW_FUNCTION = /.+?=>.+?/; | |||
There was a problem hiding this comment.
Why did you use +? not *?? I prefer *? like the above line if you don't have any reasons.
There was a problem hiding this comment.
Great catch! Yes, *? is much better. Can you make the change or do you want me to do it?
There was a problem hiding this comment.
Please make the change into your branch.
okuryu
approved these changes
Aug 20, 2019
|
Thanks! |
|
published |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug in serializeFunc. I added several unit tests until I could replicate the behavior. I think the extra unit tests are useful, but feel free to delete or alter any of them
I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.