Skip to content

bugfix: only export per token softmax kernels #266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 6, 2025
Merged

bugfix: only export per token softmax kernels #266

merged 1 commit into from
Apr 6, 2025

Conversation

DefTruth
Copy link
Member

@DefTruth DefTruth commented Apr 6, 2025

fix #251

@DefTruth DefTruth requested a review from Copilot April 6, 2025 13:05
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.

Files not reviewed (1)
  • kernels/softmax/softmax.cu: Language not supported
Comments suppressed due to low confidence (2)

kernels/softmax/softmax.py:58

  • [nitpick] The comment marker uses a double hashtag, which may be unintentional. Consider using a single '#' for clarity.
# # grid memory fence

README.md:281

  • [nitpick] The abbreviation 'per_tok' might be inconsistent with other naming conventions. Consider renaming it to 'per_token' for better clarity.
| ✔️ [softmax_f32_per_tok](./kernels/softmax/softmax.cu)|f32|f32|[link](./kernels/softmax/)|⭐️⭐️|

@DefTruth DefTruth merged commit e0fbb9f into main Apr 6, 2025
@DefTruth DefTruth deleted the dev branch April 6, 2025 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] softmax_f32_kernel 和 softmax_f32x4_kernel 的实现可能有误
1 participant