Skip to content

Add support for ClassJobs in Character profile #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 25, 2020
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion pyxivapi/client.py
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ async def character_search(self, world, forename, surname, page=1):


@timed
async def character_by_id(self, lodestone_id: int, extended=False, include_achievements=False, include_freecompany=False, include_freecompany_members=False, include_pvpteam=False, language="en"):
async def character_by_id(self, lodestone_id: int, extended=False, include_achievements=False, include_classjobs=False, include_freecompany=False, include_freecompany_members=False, include_pvpteam=False, language="en"):
"""|coro|
Request character data from XIVAPI.com
Please see XIVAPI documentation for more information about character sync state https://xivapi.com/docs/Character#character
Expand All @@ -73,6 +73,9 @@ async def character_by_id(self, lodestone_id: int, extended=False, include_achie
if include_achievements is True:
data.append("AC")

if include_classjobs is True:
data.append("CJ")

if include_freecompany is True:
data.append("FC")

Expand Down