bug fix in SslCertificateEqualityComparer

src/Xamarin.Auth.Android/WebAuthenticatorActivity.cs

@@ -188,7 +188,7 @@ bool Equals (SslCertificate.DName x, SslCertificate.DName y)
 				{
 					if (ReferenceEquals (x, y))
 						return true;
-					if (ReferenceEquals (x, y) || ReferenceEquals (null, y))
+					if (ReferenceEquals (x, null) || ReferenceEquals (null, y))
 						return false;
 					return x.GetDName().Equals (y.GetDName());
 				}

src/Xamarin.Auth/WebEx.cs

@@ -69,26 +69,47 @@ public static Task<WebResponse> GetResponseAsync (this WebRequest request)
 		}
 
 		static char[] AmpersandChars = new char[] { '&' };
-		static char[] EqualsChars = new char[] { '=' };
 
 		public static IDictionary<string, string> FormDecode (string encodedString)
-		{
-			var inputs = new Dictionary<string, string> ();
-
-			if (encodedString.StartsWith ("?") || encodedString.StartsWith ("#")) {
-				encodedString = encodedString.Substring (1);
-			}
-
-			var parts = encodedString.Split (AmpersandChars);
-			foreach (var p in parts) {
-				var kv = p.Split (EqualsChars);
-				var k = Uri.UnescapeDataString (kv[0]);
-				var v = kv.Length > 1 ? Uri.UnescapeDataString (kv[1]) : "";
-				inputs[k] = v;
-			}
-
-			return inputs;
-		}
+		{
+            var inputs = new Dictionary<string, string>();
+
+            if (encodedString.Length > 0)
+            {
+                char firstChar = encodedString[0];
+                if (firstChar == '?' || firstChar == '#')
+                {
+                    encodedString = encodedString.Substring(1);
+                }
+
+                if (encodedString.Length > 0)
+                {
+                    var parts = encodedString.Split(AmpersandChars, StringSplitOptions.RemoveEmptyEntries);
+
+                    foreach (var part in parts)
+                    {
+                        var equalsIndex = part.IndexOf('=');
+
+                        string key;
+                        string value;
+                        if (equalsIndex >= 0)
+                        {
+                            key = Uri.UnescapeDataString(part.Substring(0, equalsIndex));
+                            value = Uri.UnescapeDataString(part.Substring(equalsIndex + 1));
+                        }
+                        else
+                        {
+                            key = Uri.UnescapeDataString(part);
+                            value = string.Empty;
+                        }
+
+                        inputs[key] = value;
+                    }
+                }
+            }
+
+            return inputs;
+        }
 
 		public static Dictionary<string, string> JsonDecode (string encodedString)
 		{