Skip to content

VoteCard Component #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Th1nkK1D opened this issue Oct 5, 2023 · 3 comments
Closed

VoteCard Component #5

Th1nkK1D opened this issue Oct 5, 2023 · 3 comments
Assignees
@fResult
Labels
hacktoberfest

Comments

@Th1nkK1D
Copy link
Contributor

Th1nkK1D commented Oct 5, 2023 •
edited
Loading

image

See Figma file

Starting point

  • Create a new component with yarn gen:component
  • Can develop the component in Histoire with yarn story:dev
  • Should have voting and highlightedVoteByGroups props which are the same type as described in the Interface VoteCard in src/routes/assemblies/[id]/+page.ts
  • 3 variations from the design depend on voting.result, either if it's DefaultVotingResult.Passed, DefaultVotingResult.Failed, or any string
@fResult
Copy link
Contributor

fResult commented Oct 6, 2023

I wanna do this issue krub 🙂

fResult added a commit to fResult/parliament-watch that referenced this issue Oct 7, 2023
@fResult
feat(wevisdemo#5): add story for VoteCard component
a7c35c0
@fResult
Copy link
Contributor

fResult commented Oct 7, 2023 •
edited
Loading

Finished krub
Pull Request: fResult/#5 VoteCard Component

VoteCard.story.svelte file

fResult added a commit to fResult/parliament-watch that referenced this issue Oct 7, 2023
@fResult
feat(wevisdemo#5): make VoteCard story component is able to custom ca…
acc397b 
…ndidate name
fResult added a commit to fResult/parliament-watch that referenced this issue Oct 7, 2023
@fResult
feat(wevisdemo#5): use Design Tokens for typography instead of Tailwi…
ee77002 
…indCSS utility classes for
fResult added a commit to fResult/parliament-watch that referenced this issue Oct 7, 2023
@fResult
feat(wevisdemo#5): use Design Tokens for typography instead of Tailwi…
978de69 
…indCSS utility classes
fResult added a commit to fResult/parliament-watch that referenced this issue Oct 7, 2023
@fResult
feat(wevisdemo#5): use Design Tokens for typography instead of Tailwi…
e11c7e9 
…indCSS utility classes
fResult added a commit to fResult/parliament-watch that referenced this issue Oct 9, 2023
@fResult
feat(wevisdemo#5): fix follow code reviewed
5865596
@Th1nkK1D
Copy link
Contributor Author

Th1nkK1D commented Oct 9, 2023

Merged #8

@Th1nkK1D Th1nkK1D closed this as completed Oct 9, 2023
Th1nkK1D pushed a commit that referenced this issue Oct 9, 2023
@fResult
feat(#5): add VoteCard Component (#8)
ce0da79 
* feat(5): create vote card

* feat(#5): add story for VoteCard component

* feat(#5): make VoteCard story component is able to custom candidate name

* feat(#5): use Design Tokens for typography instead of TailwiindCSS utility classes

* feat(#5): fix follow code reviewed
fResult added a commit to fResult/parliament-watch that referenced this issue Oct 10, 2023
@fResult
feat(wevisdemo#5): add story for VoteCard component
72b67da
fResult added a commit to fResult/parliament-watch that referenced this issue Oct 10, 2023
@fResult
feat(wevisdemo#5): fix follow code reviewed
7352630
fResult added a commit to fResult/parliament-watch that referenced this issue Oct 10, 2023
@fResult
feat(wevisdemo#5): change wording for the candidate voting
7e250bc
fResult added a commit to fResult/parliament-watch that referenced this issue Oct 10, 2023
@fResult
feat(wevisdemo#5): change wording for the candidate voting
870be99
fResult added a commit to fResult/parliament-watch that referenced this issue Oct 10, 2023
@fResult
feat(wevisdemo#5): change wording for the candidate voting
581fc19
fResult added a commit to fResult/parliament-watch that referenced this issue Oct 10, 2023
@fResult
feat(wevisdemo#5): change wording for the candidate voting
2104624
Th1nkK1D pushed a commit that referenced this issue Oct 11, 2023
@fResult
feat(#5) change wording for the candidate voting (#23)
fa615f7
svnnynior pushed a commit to svnnynior/parliament-watch that referenced this issue Nov 17, 2023
@fResult
feat(wevisdemo#5): add VoteCard Component (wevisdemo#8)
7213306 
* feat(5): create vote card

* feat(wevisdemo#5): add story for VoteCard component

* feat(wevisdemo#5): make VoteCard story component is able to custom candidate name

* feat(wevisdemo#5): use Design Tokens for typography instead of TailwiindCSS utility classes

* feat(wevisdemo#5): fix follow code reviewed
svnnynior pushed a commit to svnnynior/parliament-watch that referenced this issue Nov 17, 2023
@fResult
feat(wevisdemo#5) change wording for the candidate voting (wevisdemo#23)
1da1a1a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fResult fResult

Labels
hacktoberfest
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Th1nkK1D @fResult