remove dev and docs requirement locks, opting for constraints instead #294
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jefftriplett
reviewed
Aug 8, 2024
| @@ -17,6 +17,10 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/). | |||
|
|
|||
| ## [Unreleased] | |||
|
|
|||
| ### Changed | |||
|
|
|||
| - Instead of generating a separate requirements file for both the `dev` and `docs` extras, we now only generate a requirements file for the primary production dependencies and use the ability of `uv pip install` to install directly from a `pyproject.toml` file in development. The production requirements are used as a constraint, so there should be no version mismatches. | |||
jefftriplett
reviewed
Aug 8, 2024
| @@ -82,7 +82,7 @@ jobs: | |||
|
|
|||
| - name: Install dependencies | |||
| run: | | |||
| python -m uv pip install --system -r requirements.txt -r requirements.dev.txt | |||
| python -m uv pip install --system --constraint requirements.txt --requirement pyproject.toml --extra dev | |||
There was a problem hiding this comment.
I assume that this installs everything plus everything in dev?
Asking because there used to be the opposite behavior where pip would only install dev (or so I thought).
There was a problem hiding this comment.
Yup, AFAIK it installs all the deps listed as primary and as well as the extras specified. Since the majority of them aren't pinned in the list in pyproject.toml, the constraint on the versions listed in requirements.txt helps specify what to install.
jefftriplett
approved these changes
Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.