Unify the event skipping algorithm when there is no event handler. #1417
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes fetch events, functional events, and message events use the same algorithm to determine whether to skip firing the event, and makes it a *may* rather than *must*. It also unifies the concept of a stale registration to reduce duplicated text.
jakearchibald
approved these changes
Jun 5, 2019
docs/index.bs
Outdated
| @@ -2926,7 +2934,7 @@ spec: webappsec-referrer-policy; urlPrefix: https://w3c.github.io/webappsec-refe | |||
| The |task| *must* use |activeWorker|'s [=event loop=] and the [=handle functional event task source=]. | |||
|
|
|||
| 1. Wait for |task| to have executed or been discarded. | |||
| 1. If the time difference in seconds calculated by the current time minus |registration|'s [=last update check time=] is greater than 86400, invoke [=Soft Update=] algorithm with |registration|. | |||
| 1. If |registration| is [=stale=], then run the [=Soft Update=] algorithm with |registration|. | |||
There was a problem hiding this comment.
Should this also be in parallel?
There was a problem hiding this comment.
Done. I noticed this too and thought I'd just keep the existing behavior, but yea it looks right to do it in parallel. I'm also wondering if there's a point to "Wait for |task| to have executed..." but will leave it for now.
|
Thanks, also propagated changes to v1. |
This was referenced Jun 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes {install,activate,fetch,message} events and
functional events use the same algorithm to determine
whether to skip firing the event, and makes it a may
rather than must.
It also unifies the concept of a stale registration to reduce
duplicated text.
Addresses #1200
Preview | Diff