Skip to content

[WIP][Bugfix] Minimax-VL-01 fix processing #17833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 30 commits into
base: main
Choose a base branch
from

Conversation

qscqesze
Copy link
Contributor

@qscqesze qscqesze commented May 8, 2025

WIP.

Follow-up to #16328

qscqesze added 30 commits May 6, 2025 20:15
…ity.

Signed-off-by: qingjun <qingjun@minimaxi.com>
Signed-off-by: qingjun <qingjun@minimaxi.com>
Signed-off-by: qingjun <qingjun@minimaxi.com>
Signed-off-by: qingjun <qingjun@minimaxi.com>
Signed-off-by: qingjun <qingjun@minimaxi.com>
Signed-off-by: qingjun <qingjun@minimaxi.com>
Signed-off-by: qingjun <qingjun@minimaxi.com>
Signed-off-by: qingjun <qingjun@minimaxi.com>
Signed-off-by: qingjun <qingjun@minimaxi.com>
Signed-off-by: qingjun <qingjun@minimaxi.com>
Signed-off-by: qingjun <qingjun@minimaxi.com>
Signed-off-by: qingjun <qingjun@minimaxi.com>
Signed-off-by: qingjun <qingjun@minimaxi.com>
Signed-off-by: qingjun <qingjun@minimaxi.com>
Signed-off-by: qingjun <qingjun@minimaxi.com>
Signed-off-by: qingjun <qingjun@minimaxi.com>
Signed-off-by: qingjun <qingjun@minimaxi.com>
Signed-off-by: qingjun <qingjun@minimaxi.com>
Signed-off-by: qingjun <qingjun@minimaxi.com>
Signed-off-by: qingjun <qingjun@minimaxi.com>
Signed-off-by: qingjun <qingjun@minimaxi.com>
Signed-off-by: qingjun <qingjun@minimaxi.com>
Signed-off-by: qingjun <qingjun@minimaxi.com>
Signed-off-by: qingjun <qingjun@minimaxi.com>
Signed-off-by: qingjun <qingjun@minimaxi.com>
Copy link

github-actions bot commented May 8, 2025

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@qscqesze
Copy link
Contributor Author

qscqesze commented May 8, 2025

@DarkLight1337
Hi, I have a question regarding the use of vllm/model_executor/models/minimax_cache.py. We're relying on this module, and its initialization depends on the request_ids_to_seq_ids and finished_requests_ids fields. These fields are part of ModelInput, but they're not available when using DummyRun.
Do you have any suggestions on how to handle this, or how we might construct these two fields?
Previously, I noticed that these fields were included in attn_metadata, which has since been removed.

@DarkLight1337
Copy link
Member

@ywang96 might have a better idea regarding this.

Copy link

mergify bot commented May 15, 2025

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @qscqesze.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mergify mergify bot added the needs-rebase label May 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants