Skip to content

[Model] Add GraniteMoeHybrid 4.0 model #17461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 0 commits into from

Conversation

s3woz
Copy link
Contributor

@s3woz s3woz commented Apr 30, 2025

The PR adds support for upcoming Granite4.0 models. It is a companion PR to huggingface/transformers#37658 for adding the same model to HF.

Please note that model paths are local for now, but I will provide HF URLs asap.

@tdoublep

Copy link

mergify bot commented Apr 30, 2025

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @s3woz.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mergify mergify bot added the needs-rebase label Apr 30, 2025
Comment on lines 566 to 572
def sample(
self,
logits: Optional[torch.Tensor],
sampling_metadata: SamplingMetadata,
) -> Optional[SamplerOutput]:
next_tokens = self.sampler(logits, sampling_metadata)
return next_tokens
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sampler isn't defined inside model anymore (see #17084 )

@@ -0,0 +1,39 @@
# SPDX-License-Identifier: Apache-2.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heads up that we will move the model tests in #17459

Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@s3woz s3woz force-pushed the granitemoehybrid_clean branch 2 times, most recently from a365669 to d433d2d Compare April 30, 2025 09:52
@mergify mergify bot added documentation Improvements or additions to documentation ci/build frontend multi-modality Related to multi-modality (#4194) v1 tpu Related to Google TPUs tool-calling labels Apr 30, 2025
@s3woz s3woz force-pushed the granitemoehybrid_clean branch from d433d2d to e1ba9e8 Compare April 30, 2025 10:16
@mergify mergify bot removed the tpu Related to Google TPUs label Apr 30, 2025
@s3woz s3woz force-pushed the granitemoehybrid_clean branch from c45809d to e1ba9e8 Compare April 30, 2025 10:40
@s3woz s3woz closed this Apr 30, 2025
@s3woz s3woz force-pushed the granitemoehybrid_clean branch from c45809d to d803786 Compare April 30, 2025 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/build documentation Improvements or additions to documentation frontend multi-modality Related to multi-modality (#4194) needs-rebase tool-calling v1
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants