Skip to content

[Chore] ignore override default __init__.py when building from source #17260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

aarnphm
Copy link
Collaborator

@aarnphm aarnphm commented Apr 27, 2025

This PR continues from #17228 where installing from source will override vllm_flash_attn/__init__.py

Signed-off-by: Aaron Pham contact@aarnphm.xyz

Signed-off-by: Aaron Pham <contact@aarnphm.xyz>
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@aarnphm aarnphm requested a review from DarkLight1337 April 27, 2025 13:18
@mergify mergify bot added the ci/build label Apr 27, 2025
@DarkLight1337
Copy link
Member

Does this fix both #17246 and #17247?

@aarnphm
Copy link
Collaborator Author

aarnphm commented Apr 27, 2025

I can include #17247 here.

#17246 i need to see their ds.py, but i would assume that it is importing the stubs file instead of the actual file somehow.

@DarkLight1337
Copy link
Member

If #17247 doesn't overlap with this PR then let's keep them separate

@DarkLight1337 DarkLight1337 enabled auto-merge (squash) April 27, 2025 13:30
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Apr 27, 2025
@aarnphm
Copy link
Collaborator Author

aarnphm commented Apr 27, 2025

Superceded by #17267

@aarnphm aarnphm closed this Apr 27, 2025
auto-merge was automatically disabled April 27, 2025 16:45

Pull request was closed

@aarnphm aarnphm deleted the chore/ignore-copy-init branch April 27, 2025 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/build ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants