Skip to content

[V1] Avoid socket errors during shutdown when requests are in in-flight #16807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 23, 2025
Merged

[V1] Avoid socket errors during shutdown when requests are in in-flight #16807

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion vllm/v1/engine/core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -384,7 +384,7 @@ def signal_handler(signum, frame):

except SystemExit:
logger.debug("EngineCore exiting.")

raise
except Exception as e:
if engine_core is None:
logger.exception("EngineCore failed to start.")
Expand Down
10 changes: 6 additions & 4 deletions vllm/v1/engine/core_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -312,6 +312,7 @@ class BackgroundResources:
def __call__(self):
"""Clean up background resources."""

self.engine_dead = True
for core_engine in self.core_engines:
core_engine.close()

Expand Down Expand Up @@ -564,7 +565,7 @@ def add_request(self, request: EngineCoreRequest) -> None:
self._send_input(EngineCoreRequestType.ADD, request)

def abort_requests(self, request_ids: list[str]) -> None:
if len(request_ids) > 0:
if request_ids and not self.resources.engine_dead:
self._send_input(EngineCoreRequestType.ABORT, request_ids)

def profile(self, is_start: bool = True) -> None:
Expand Down Expand Up @@ -735,7 +736,7 @@ async def add_request_async(self, request: EngineCoreRequest) -> None:
self._ensure_output_queue_task()

async def abort_requests_async(self, request_ids: list[str]) -> None:
if len(request_ids) > 0:
if request_ids and not self.resources.engine_dead:
await self._send_input(EngineCoreRequestType.ABORT, request_ids)

async def profile_async(self, is_start: bool = True) -> None:
Expand Down Expand Up @@ -895,5 +896,6 @@ async def abort_requests_async(self, request_ids: list[str]) -> None:

async def _abort_requests(self, request_ids: list[str],
engine: CoreEngine) -> None:
await self._send_input(EngineCoreRequestType.ABORT, request_ids,
engine)
if not self.resources.engine_dead:
await self._send_input(EngineCoreRequestType.ABORT, request_ids,
engine)