-
Notifications
You must be signed in to change notification settings - Fork 130
Use model compression pathways #1419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
kylesayrs
wants to merge
8
commits into
main
Choose a base branch
from
kylesayrs/use-memory-compression-pathways
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+63
−73
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kyle Sayers <kylesayrs@gmail.com>
👋 Hi! Thank you for contributing to llm-compressor. Please add the ready label when the PR is ready for review. Note: This is required to complete the testing suite, please only add the label once the PR is code complete and local testing has been performed. |
Signed-off-by: Kyle Sayers <kylesayrs@gmail.com>
Signed-off-by: Kyle Sayers <kylesayrs@gmail.com>
Signed-off-by: Kyle Sayers <kylesayrs@gmail.com>
Signed-off-by: Kyle Sayers <kylesayrs@gmail.com>
Signed-off-by: Kyle Sayers <kylesayrs@gmail.com>
Signed-off-by: Kyle Sayers <kylesayrs@gmail.com>
brian-dellabetta
approved these changes
May 20, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
exciting!
dsikka
pushed a commit
that referenced
this pull request
May 20, 2025
…1449) ## Purpose ## * Prerequisite for #1419 * This PR disables getting the offloaded state dict unless necessary (sparsity statistics). However, the utility function `cpu_offload` only works if the offloaded state dict is retrieved. Let's replace this with `dispatch_model`, which is the actual function used by `PretrainedModel`, not `cpu_offload` ## Changes ## * Rename `device_map` to `device` * Use `dispatch_model` rather than `cpu_offload` * Use `align_module_device` and `update_offload_parameter` utilities * This change is necessary because, after these changes, some of these test models no longer have offloaded state dicts (which is the way it should always have been) Signed-off-by: Kyle Sayers <kylesayrs@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
save_pretrained
manuallyPrerequisites
test_compress_tensor_utils
#1449Changes
save_pretrained_wrapper
to usecompress_model(model)
rather thancompress(state_dict)
save_pretrained_wrapper
so that the state dict is only retrieved if not skipping compression statssave_pretrained_wrapper
to save dictionary and python files, even if there is no explicit compressorsave_checkpoint
(used by training) to decompress after the checkpoint is savedExample/Testing Changes
As far as I can tell, below lists all of the instances where a model undergoes saving (no immediately followed by script exit)
test_oneshot_and_finetune.py
test_oneshot_and_finetune_with_tokenizer.py
dispatch_model
(which is actually used by transformers) rather thancpu_offload
Testing
oneshot_save.py