validation check added

[ved1beta]

SUMMARY:
added a validation check in create_modifier
fixes #1226

[github-actions]

👋 Hi! Thank you for contributing to llm-compressor. Please add the ready label when the PR is ready for review.

Note: This is required to complete the testing suite, please only add the label once the PR is code complete and local testing has been performed.

[kylesayrs]

Hi @ved1beta ! Could you provide more context as to when this code would be useful?

I also see here that valid_fields is undeclared in some cases, you may want to make sure that that variable is declared in all cases, or make explicit the assumption that all modifiers have model fields

[ved1beta]

validation check useful when is writing recipes for modifiers. The specific issue being fixed (issue #1226) occurs when users specify invalid or irrelevant arguments in a modifier's configuration. Without this validation, the system silently accepts invalid arguments, which can lead to several issues. Eg

[kylesayrs]

@ved1beta I see! Have you explored Pydantic's extra="forbid" option at all?

class Model(BaseModel):
    x: int

    model_config = ConfigDict(extra="forbid")

[kylesayrs]

Sorry, I was actually referencing adding the forbid option directly to the Modifier class. This might be simpler than attempting to create a temporary base class as an intermediary

[kylesayrs]

I was actually suggesting to add the extra forbid config to the Modifier class, directly. This solution also covers cases where users create modifiers directly, rather than going through the ModifierFactory