Skip to content

[Callbacks] Merge on_event with on_update, remove MagnitudePruningModifier.leave_enabled #1199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

kylesayrs
Copy link
Collaborator

@kylesayrs kylesayrs commented Feb 26, 2025

Purpose

  • Remove the concept of "on_update" and replace it with on_event, which is triggered only when a modifier has started
  • Remove MagnitudePruningModifier.leave_enabled, which was used to simplify recipes but can be replaced by a subsequent ConstantPruningModifier, which much clearer conceptually

Prerequisites

Changes

  • Raise a warning when when a modifier receives an event but hasn't been initialized
  • Trigger on_event between starting and stopping
  • Rename on_update to on_event to remove the concept of "updating" a modifier

Signed-off-by: Kyle Sayers <kylesayrs@gmail.com>
Signed-off-by: Kyle Sayers <kylesayrs@gmail.com>
Signed-off-by: Kyle Sayers <kylesayrs@gmail.com>
@vllm-project vllm-project deleted a comment from github-actions bot Feb 26, 2025
@kylesayrs kylesayrs self-assigned this Feb 26, 2025
@kylesayrs kylesayrs changed the base branch from main to kylesayrs/remove-leave_enabled February 26, 2025 18:39
Base automatically changed from kylesayrs/remove-leave_enabled to main March 7, 2025 18:23
@kylesayrs kylesayrs dismissed brian-dellabetta’s stale review March 7, 2025 18:23

The base branch was changed.

Signed-off-by: Kyle Sayers <kylesayrs@gmail.com>
@kylesayrs kylesayrs changed the title [Callbacks] Remove on_update [Callbacks] Merge on_event with on_update Mar 12, 2025
@kylesayrs kylesayrs added the ready When a PR is ready for review label Mar 12, 2025
@kylesayrs kylesayrs changed the title [Callbacks] Merge on_event with on_update [Callbacks] Merge on_event with on_update, remove MagnitudePruningModifier.leave_enabled Mar 12, 2025
Signed-off-by: Kyle Sayers <kylesayrs@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready When a PR is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants