Stub errorInfo() to prevent upstream issues #22
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Native PDO code expects constructor called for the method to work and returns `null` under circumstances.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The library is written for exception error handling (which is fine), but if any code treats it as generic PDO and calls
errorInfo()things fall apart:No error: PDO constructor was not calledwarning, that isn't easy to work around.null, rather than supposed three fields array structure.Since the any real error would be an exception anyway, I stubbed the methods to hardcode a no-error state for anything that asks.
Not confident that is the way to go about it, but don't have a better idea. Open to explore alternative takes if there are any pointers. :)