New tasks: Squat and Light #450
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Something that I missed from Alarmy was their Squat task, which had me get out of bed and do squats (counted w/ accelerometer data) in order to turn off the alarm. Ever since they switched over to premium, I haven't had access to that, so I decided to contribute it to this app instead!
I also added another task called "Light", which requires the light sensor to get to a certain value to dismiss. The idea is to have the user turn on the light in order to have their alarm stop.
This is my first PR in Dart (along with #451 ), so any code review or constructive criticism is welcome! :) I'm open to do any edits that you'd like in order to get it to project standards!