Upload session query method compatible with memoryfs python library #656
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python's
memoryfs
library handles reading and writing memory files. The open method fromMemoryFS
class instantiate aMemoryFile
object.MemoryFile
class inherits fromio.RawIOBase
class, thus it can be passed to thefile_object
parameter of thecreate_upload_session_query
method.However,
MemoryFile
does not implements the methodfileno()
(used on the line 34, to getfile_size
), also, the methodos.path.basename()
(used on the line 35 to getfile_name
) cannot parseMemoryFS
paths.As a solution to turn
create_upload_session_query
method compatible, I added 2 optional parametersfile_size
andfile_name
, so IO objects (asMemoryFile
objects) can provide them from the outside of method.This solution does not break the current usage of the method.