Add pagination support to backend #183
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
evelynl94
reviewed
Jun 26, 2019
codygibb
reviewed
Jun 26, 2019
codygibb
approved these changes
Jun 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #22
The backend's
Clientinterface'sListmethod is modified to add an addition parameterListOptions. These parameters control pagination and potentially more settings in the future.Listalso returns an additional value, which is the continuation token. This will be an empty string if there is no more entries to list.The
s3backendhas been modified to return a page of results and the continuation token if pagination was enabled. If pagination is not enabled the behavior of the backend does not change. Other backends will return an error if pagination is attempted to be used on them. The behavior of these backends has not been modified if pagination is not enabled.Currently nothing has been modified to take advantage of s3's pagination support.