Don't map Insert mode meta chords during macro #30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes tpope#13 The CursorHoldI event isn't triggered during macro execution, even when updatetime is set to zero. We can use this 'feature' to create mappings on the CursorHoldI event only when the user manually enters Insert mode.
|
I think anything this dicey should probably just be made into a separate, general purpose plugin, no? RSI continues to provide |
|
Sure, I can see this being a separate plugin. Feel free to use and refactor the code however you think is best. Yeah, it's a dicey hack but seems to work consistently. I'm not sure why we have to use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's a potential fix for issue #13. To test the fix, edit a file with the following contents:
Then search
/foo<CR>, record a macroggqqciwbar<Esc>nq, and execute the macro a few times4@q. The important part of the macro that's being tested is the<Esc>nsequence, which vim-rsi remaps.