Make the case-insensitive text matching only when TextMatch is a string. #23
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Convert the matched text to lowercase only when TextMatch is a string.
Why:
Converting it to lowercase for all types of TextMatch breaks case sensitive RegExp matching (#21)
How:
In
matches.js
, only convert thenormalizedText
to lowercase if TextMatch is a string. I think that should preserve the case-insensitive nature of matching when TextMatch is a string. I have chosen to leave the case when TextMatch is a function as case-sensitive as well, since this situation is supposed to delegate as much control back to the user.Checklist: