Skip to content

cargo clippy: allow vec_box #349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 20, 2019
Merged

Conversation

spl
Copy link
Contributor

@spl spl commented Mar 20, 2019

Don't warn about vec_box.

@spl
Copy link
Contributor Author

spl commented Mar 20, 2019

This is the last of the clippy lints.

@pkgw pkgw self-assigned this Mar 20, 2019
@codecov
Copy link

codecov bot commented Mar 20, 2019

Codecov Report

Merging #349 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #349   +/-   ##
======================================
  Coverage    39.6%   39.6%           
======================================
  Files         135     135           
  Lines       59482   59482           
======================================
  Hits        23560   23560           
  Misses      35922   35922
Impacted Files Coverage Δ
src/engines/mod.rs 63.96% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae553d3...f0cce70. Read the comment docs.

@pkgw
Copy link
Collaborator

pkgw commented Mar 20, 2019

OK, I believe that the suppression functionality used here was introduced in 1.30: related doc issue. That version was released on 2018-10-25. This might cause problems for older Rusts, but (as discussed in #345) we don't have a specific policy about what versions we support, so ¯\_(ツ)_/¯.

@pkgw pkgw merged commit bc96c38 into tectonic-typesetting:master Mar 20, 2019
@spl
Copy link
Contributor Author

spl commented Mar 20, 2019 via email

@spl spl deleted the clippy-vec_box branch March 22, 2019 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants