Skip to content

fix(security): ensure wiki sidebar generation isn't vulnerable to reg… #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 27, 2024

Conversation

virgofx
Copy link
Member

@virgofx virgofx commented Oct 27, 2024

The regex pattern to match ## or ### was initially vulnerable to potential DOS backtracking via the ".+" pattern. This fix prevents that by using a different character group matching pattern.

…ex backtracking

The regex pattern to match ## or ### was initially vulnerable to
potential DOS backtracking via the ".+" pattern. This fix prevents that
by using a different character group matching pattern.
@virgofx virgofx self-assigned this Oct 27, 2024
Copy link

@virgofx virgofx added the bug Something isn't working label Oct 27, 2024
Copy link

Release Plan

No terraform modules updated in this pull request.

✅ Wiki Check ℹ️

Note: The following Terraform modules no longer exist in source; however, corresponding tags/releases exist. Automation tag/release deletion is disabledno subsequent action will take place.

v1.2.0, v1.1.1, v1.1.0, v1.0.1, v1.0.0, v1

Powered by techpivot/terraform-module-releaser

@virgofx virgofx merged commit 0cd795d into main Oct 27, 2024
7 checks passed
@virgofx virgofx deleted the fix/security-issue-wiki-heading-regex-backtracking branch October 27, 2024 23:30
@release-preview release-preview bot mentioned this pull request Oct 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant