Skip to content

[Diagnostics] Split "only concrete types conform to protocols" into a separate note #34467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 28, 2020
Merged

[Diagnostics] Split "only concrete types conform to protocols" into a separate note #34467

merged 2 commits into from
Oct 28, 2020

Conversation

xedin
Copy link
Contributor

@xedin xedin commented Oct 27, 2020

This is purely a usability improvement since part about concrete types could be useful in some more places
and not just for conformance error.

@xedin xedin requested a review from hborla October 27, 2020 21:55
@xedin
Copy link
Contributor Author

xedin commented Oct 27, 2020

@swift-ci please smoke test

@xedin
Copy link
Contributor Author

xedin commented Oct 27, 2020

@swift-ci please smoke test macOS platform

@xedin xedin merged commit 811fc06 into swiftlang:main Oct 28, 2020
@rintaro rintaro mentioned this pull request Oct 30, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hborla hborla hborla approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xedin @hborla