[Dependency Scanner] Do not escape strings in the scanner output #34360
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
When outputting strings for things like filenames, using `write_escaped` will result in Unicode characters being outputted with a full 3-character-octal or hex escape. Clients which expect a UTF-8 JSON output will not be able to parse such escape sequences.
artemcm
force-pushed
the
DoNotEscapeScannerOutputStrings
branch
from
94365bb to
d7a6ded
Compare
|
@swift-ci please smoke test |
artemcm
commented
Oct 20, 2020
| @@ -0,0 +1,3 @@ | |||
| func foo() { | |||
| print(1) | |||
There was a problem hiding this comment.
Having an actual test itself have a Unicode character in its filename seems to trip up lit test infra.
|
Build failed |
|
@swift-ci please smoke test Windows platform |
|
Build failed |
|
@swift-ci please test Windows platform |
nkcsgexi
approved these changes
Oct 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When outputting strings for things like filenames, using
write_escapedwill result in Unicode characters being outputted with a full 3-character-octal or hex escape. Clients which expect a UTF-8 JSON output will not be able to parse such escape sequences.