[silgen] Ensure that cleanup cloner clones formal access cleanups to formal access cleanups. #34357
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…formal access cleanups. This has been a long standing issue that we have been hacking around in various points in SILGen. Now CleanupCloner just does the right thing. I was unable to cause any issues to pop up in tree (since I believe we hacked around this and converged on correctness). But it does come up in combination with new code in swiftlang#31779. rdar://63514765
|
@swift-ci test |
|
@swift-ci test source compatibilité |
|
@swift-ci test windows platform |
|
@swift-ci test source compatibility |
|
The source compatibility failure is a known unrelated failure. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has been a long standing issue that we have been hacking around in various
points in SILGen. Now CleanupCloner just does the right thing.
I was unable to cause any issues to pop up in tree (since I believe we hacked
around this and converged on correctness). But it does come up in combination
with new code in #31779.
rdar://63514765