[Diagnostics] Use constant strings to avoid use after free. #27980
Conversation
Using std::string in the function signature copies the constant string into a stack allocated copy, which is the one referenced by the StringRef that DiagnosticInfo stores. when the stack is abandoned, the string seems to be modificed in VC++, which makes the test fail in Windows. Using const char * in the signature avoids the std::string creation, and StringRef will refer to the static data instead.
|
(testing locally at the same time) @swift-ci please test Windows platform |
|
@swift-ci please smoke test |
There was a problem hiding this comment.
Thanks for catching this, sorry about the breakage @drodriguez !
|
@swift-ci please clean test Windows platform |
|
Is a known error? Seems to be happening also in other PRs, so I doubt is related to this change. |
|
I'm seeing an error from the |
|
@swift-ci please smoke test linux platform |
1 similar comment
|
@swift-ci please smoke test linux platform |
|
@swift-ci please smoke test Linux platform |
|
@compnerd I'm pretty sure this is going to fail again, swiftlang/swift-package-manager#2394 should fix the swiftbench issue |
|
Please test with following PR: @swift-ci please smoke test Linux platform |
|
@swift-ci please smoke test Linux platform |
Using std::string in the function signature copies the constant string
into a stack allocated copy, which is the one referenced by the
StringRef that DiagnosticInfo stores. when the stack is abandoned, the
string seems to be modificed in VC++, which makes the test fail in
Windows.
Using const char * in the signature avoids the std::string creation, and
StringRef will refer to the static data instead.
Intreoduced in #27868 and started to fail in https://ci-external.swift.org/job/oss-swift-windows-x86_64/1790
/cc @owenv