Skip to content

[CI] Add soundness check #824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Sep 30, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .github/workflows/pull_request.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,3 +8,10 @@ jobs:
tests:
name: Test
uses: swiftlang/github-workflows/.github/workflows/swift_package_test.yml@main
soundness:
name: Soundness
uses: swiftlang/github-workflows/.github/workflows/soundness.yml@main
with:
format_check_enabled: false
license_header_check_enabled: false
license_header_check_project_name: "Swift.org"
2 changes: 1 addition & 1 deletion Documentation/PrettyPrinter.md
Original file line number Diff line number Diff line change
Expand Up @@ -490,6 +490,6 @@ sense to place this label on the containing group.

Oppen's algorithm prints the indentation whitespace when `break` tokens are
encountered. If we have extra blank lines in between source code, this can
result in hanging or trailing whitespace. Waiting to print the indentation
result in hanging or trailing whitespace. Waiting to print the indentation <!--# ignore-unacceptable-language -->
whitespace until encountering a `syntax`, `comment, or `verbatim` tokens
prevents this.
2 changes: 1 addition & 1 deletion Sources/SwiftFormat/PrettyPrint/TokenStreamCreator.swift
Original file line number Diff line number Diff line change
Expand Up @@ -1104,7 +1104,7 @@ fileprivate final class TokenStreamCreator: SyntaxVisitor {
/// - rightDelimiter: The right parenthesis or bracket surrounding the arguments, if any.
/// - forcesBreakBeforeRightDelimiter: True if a line break should be forced before the right
/// right delimiter if a line break occurred after the left delimiter, or false if the right
/// delimiter is allowed to hang on the same line as the final argument.
/// delimiter is allowed to hang on the same line as the final argument. # ignore-unacceptable-language
private func arrangeFunctionCallArgumentList(
_ arguments: LabeledExprListSyntax,
leftDelimiter: TokenSyntax?,
Expand Down