CoreFoundation: Correctly construct user preferences directory #5184
+4
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Technically, this change is fine. However,I wonder if it is currently required or not. Where is this path exercised? It is slightly confusing as FileManager has migrated to swift-foundation and has an implementation which doesn’t include CoreFoundation. CC: @parkera |
|
UserDefaults class uses this, unless that has changed since I wrote this. |
compnerd
reviewed
May 5, 2025
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Putting an absolute path here as the subdirectory to append makes the home directory prefix get removed and the final path ends up as /Library/Preferences instead of ~/Library/Preferences, etc.