Skip to content

Align fatalError messages in Objective-C bridging methods for consistency #5123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

nnabeyang
Copy link
Contributor

This PR updates fatalError messages in the bridging methods of DateComponents and Notification to maintain a consistent message format across similar methods.

These changes enhance debugging clarity and ensure a uniform error message format throughout the codebase. Although these fatalError statements are not expected to be executed in practice, having consistent and clear error messages helps maintain code readability and aids potential debugging.

@parkera
Copy link
Contributor

parkera commented Oct 28, 2024

@swift-ci test

@parkera
Copy link
Contributor

parkera commented Oct 30, 2024

@swift-ci test windows

@parkera parkera merged commit 9cc5d4c into swiftlang:main Nov 1, 2024
2 checks passed
@nnabeyang nnabeyang deleted the fix-fatal_error-message-bridging-methods branch November 2, 2024 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants