Use FSR for Process executable path on Windows #4999
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iCharlesHu
approved these changes
Jul 1, 2024
| @@ -499,7 +499,7 @@ open class Process: NSObject { | |||
| } | |||
|
|
|||
| #if os(Windows) | |||
| var command: [String] = [launchPath] | |||
| var command: [String] = [try FileManager.default._fileSystemRepresentation(withPath: launchPath) { String(decodingCString: $0, as: UTF16.self) }] | |||
There was a problem hiding this comment.
Does _fileSystemRepresentation need to/can be applied on other platforms as well (just to be consistent)
There was a problem hiding this comment.
Good point, it doesn't have the same level of effect on other platforms but I'll add it for good measure
compnerd
approved these changes
Jul 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Within
Process, thelaunchPathhere is equivalent toexecutableURL.path. Just before launching the process, we call.withCString(encodedAs: UTF16.self)to convert the invocation to UTF-16. However, now thatURLis re-cored on swift-foundation'sURL, Windows paths are represented following RFC8089 which contains a leading/before a drive letter. The various file system representation functions remove this preceding slash before calling to an SDK API, howeverProcessdid not do this resulting in a path such as/C:/Users/jmschonfeld/foo.exebeing passed toCreateProcessWwhich failed to find the file. This standardizes the path to its file system representation before it is combined with the various arguments and converted to UTF-16 later.This fixes a failure that occurred during a windows toolchain build where SwiftPM (using the new Foundation) was unable to invoke
swiftc.exedue to this issue.